Handle language pack uninstallation #172082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Does this issue fix #82791? |
The most important part of this change is that we now listen for when extensions are uninstalled and if they uninstalled language currently set then a modal will show up prompting for restart (required to change the language back to English). This change also makes the LocaleService the thing that writes to the argv.json instead of a few places doing it and cleans up some of the wording.
* use a notification until there's a more reliable way to guess when an extension is installed via settings sync
TylerLeonhardt
force-pushed
the
tyler/legitimate-gull
branch
from
bba9479 to
8c1fda6
Compare
Member
Author
No nothing has changed in that regard |
joyceerhl
approved these changes
Jan 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important part of this change is that we now listen for when extensions are uninstalled and if they uninstalled language currently set then a modal will show up prompting for restart (required to change the language back to English).
This change also makes the LocaleService the thing that writes to the argv.json instead of a few places doing it
and cleans up some of the wording.
Fixes #82791