-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Closed as not planned
Labels
*out-of-scopePosted issue is not in scope of VS CodePosted issue is not in scope of VS CodedebtCode quality issuesCode quality issueselectronIssues and items related to ElectronIssues and items related to Electronupstream-issue-linkedThis is an upstream issue that has been reported upstreamThis is an upstream issue that has been reported upstreamworkbench-electronElectron-VS Code issuesElectron-VS Code issues
Description
Currently VSCode is implementing it's own solution for preventing a second instance from starting. Electron provides API to do the same but there are differences: https://github.com/electron/electron/blob/7-1-x/docs/api/app.md#apprequestsingleinstancelock
Things we need:
- pass the process environment over (second-instance event should pass ENV of requester electron/electron#18434)
- communicate between second and first instance to support
code --status
[1]
[1] code --status
will print information about the active window in the first instance to the console of the second instance and thus requires access to the workspace, including remote scenarios.
Metadata
Metadata
Assignees
Labels
*out-of-scopePosted issue is not in scope of VS CodePosted issue is not in scope of VS CodedebtCode quality issuesCode quality issueselectronIssues and items related to ElectronIssues and items related to Electronupstream-issue-linkedThis is an upstream issue that has been reported upstreamThis is an upstream issue that has been reported upstreamworkbench-electronElectron-VS Code issuesElectron-VS Code issues