Persisted data breakpoints are not registered when starting a new debug session

[weinand]

VS Code didn't respect the canPersist attribute of DataBreakpointInfoResponse well. When it is true, the BREAKPOINTS viewlet will keep it there after the debug session terminates. But when launching a new debug session, no setDataBreakpoints request are sent to debugger during initialization. The debugger has no chance to enable the persisted data breakpoints.

[isidorn]

Can not reproduce with Mock Debug which I changed to return canPersist: true for every data breakpoint.
VSCode sends the data breakopints when the new session is initalised here
Can you please create a fork of mock debug that shows this issue so I can investigate more? Thank you

Here's the gif showing that I send the persisted data breakpoint:

[weinand]

Maybe it got fixed by me reverting your async/await change...

[isidorn]

The async await chainges I have reaplied after fixing the issue for which you did the revert. But it might be some other change in the meantime fixed this

[weinand]

Aha, the issue is that the "setDataBreakpoints" is not called after a restart of VS Code.

So my bug description was wrong: instead of "But when launching a new debug session" I meant "But when launching a new VS Code session".

[isidorn]

Hmm I also can not reproduce if I restart VS Code.
Sicne we properly store data breakpoints as all other breakpoints in local storage via this code here
When I restart VS Code I get the data breakpoints back from local storage and send them properly to mock debug.

[weinand]

And you hit them properly?

[isidorn]

I forgot when mock debug hits data breakpoints. But I don't see why not, I send them properly to the adapter, it is up to the adapter to send a stopped event.
Or you can refersh my memory as to the data breakpoint logic in mock debug?