Skip to content

The work in getExecutablesInPath is done many times before caching happens #259339

@Tyriar

Description

@Tyriar

One of the reasons for #256746 might be that we don't respect the cancelation token. When I add a few logs, I see a lot of _getExecutablesInPath calls going the non-cached route just by typing in the terminal:

Image

These a, b logs should never have happened.

The fetchAndCacheShellGlobals change we did in #259051 also needs to happen for getExecutablesInPath.

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code Insidersperfterminal-suggest

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions