-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Closed
Labels
author-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue authorconfigVS Code configuration, set up issuesVS Code configuration, set up issuesextension-hostExtension host issuesExtension host issuesfeature-requestRequest for new features or functionalityRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded
Milestone
Description
- Register some configuration defaults like
{ hello: "world" }
using the web API (e.g. here for the code-server.sh script) - 🐛 notice they are still undefined when read from the local extension host (at least before a remote is resolved)
It seems like it should work because the overrides are registered here
if (environmentService.options?.configurationDefaults) { | |
this.configurationRegistry.registerDefaultConfigurations([{ overrides: environmentService.options.configurationDefaults }]); | |
} |
before the MainThreadConfiguration is even instantiated, so I would expect they get passed during initial hydration here
proxy.$initializeConfiguration(this._getConfigurationData()); |
...but they do not. I did some debugging myself but got a bit lost in config land.
Having these options is needed for a couple partner team feature asks.
Metadata
Metadata
Labels
author-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue authorconfigVS Code configuration, set up issuesVS Code configuration, set up issuesextension-hostExtension host issuesExtension host issuesfeature-requestRequest for new features or functionalityRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded