Skip to content

Support configuration contribution points of resolver extensions #224236

@connor4312

Description

@connor4312
  1. Register some configuration defaults like { hello: "world" } using the web API (e.g. here for the code-server.sh script)
  2. 🐛 notice they are still undefined when read from the local extension host (at least before a remote is resolved)

It seems like it should work because the overrides are registered here

if (environmentService.options?.configurationDefaults) {
this.configurationRegistry.registerDefaultConfigurations([{ overrides: environmentService.options.configurationDefaults }]);
}

before the MainThreadConfiguration is even instantiated, so I would expect they get passed during initial hydration here

proxy.$initializeConfiguration(this._getConfigurationData());

...but they do not. I did some debugging myself but got a bit lost in config land.

Having these options is needed for a couple partner team feature asks.

Metadata

Metadata

Labels

author-verification-requestedIssues potentially verifiable by issue authorconfigVS Code configuration, set up issuesextension-hostExtension host issuesfeature-requestRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code Insidersverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions