Offer to move VS Code to the Applications folder

[isidorn]

macOS

1. Download VS Code
2. It is in the Downloads folder
3. Run it -> all good. No dialog
4. The issue is that users leave VS Code in the Downloads folder, and then they can not auto-update 🐛 (me and @digitarald saw this happen with GH folk new to VS Code)

I just downloaded ollama, and on first run there was a dialog to offer to move to Applications.

Can we do the same?

[bpasero]

@deepak1556 isn't there support from Electron to do this? Anything that would speak against using it?

From https://github.com/electron/electron/blob/main/docs/api/app.md

[bpasero]

One thing to keep in mind is that we have lots of scenarios where we would not want such a dialog, for example CI smoke test runs or VS Code bisect runs.

[isidorn]

@bpasero thanks for smart comments.
Yeah, we would need flag to disable, so that CI and bisect runs can circumvent this.

[deepak1556]

isn't there support from Electron to do this? Anything that would speak against using it?

Yup, api was made specifically for this use case electron/electron#1692. I can't think of a reason to not use it.

[isidorn]

Assigning to myself and August just to not loose track of this.

[joaomoreno]

The issue is that users leave VS Code in the Downloads folder, and then they can not auto-update

Note that this feature would likely not solve the problem above. Not being able to auto-update is a symptom of having the app in quarantine, which macOS does by default to an app that just got downloaded. We have code to detect this:

vscode/src/vs/workbench/contrib/update/browser/update.ts

Line 286 in 7cbcafc

error = error.replace(/See https:\/\/github\.com\/Squirrel\/Squirrel\.Mac\/issues\/182 for more information/, 'This might mean the application was put on quarantine by macOS. See [this link](https://github.com/microsoft/vscode/issues/7426#issuecomment-425093469) for more information');

Before we commit to doing this, let's verify whether it helps at all with the initial problem of users being unable to update.