Expose ILinkSupport in API

[IgnacioHR]

Hi, I've started to write an extension to provide support for W3C XLink Specification to the xml language the xlink specification provides attributes to document links from an XML fragment o another XML fragment.

At the time I find an xlink:href attribute on an XML node I'm able to create a customized decoration on the attribute value but I'm unable to find the way to properly implement a mechanism to detect when the user has clicked on the decoration. I've actually implemented a DefinitionProvider that is able to open the document but the user must press F12 or right click on the text and select "Go to Definition" but a link is not a Definition but just the link end point.

Cheers,
Ignacio

[joaomoreno]

@alexandrudima ping

[alexdima]

@jrieken How do you think we should better handle this?

Should we expose ILinkSupport in the api and accumulate & dedup the links from all parties? Or should DefinitionProvider be expanded in scope to capture any link?

[jrieken]

@IgnacioHR Are the documents those links point to usually inside the workspace or something like a http-url that you want to be opened in a browser?

[IgnacioHR]

Links points anywhere. They are just links. The URI is resolved using xml:base standard resolution and the target file might be local or external. When local, I open it on a side editor and I find the target element so it is highlighted.

[jrieken]

Thanks. I think the best will be expose the ILinkSupport in some form. VS Code (as today) will come with a decent default implementation but for special cases (like above) you can mark for regions of a document as hyperlink.

[IgnacioHR]

Sounds good to me. Thanks