Skip to content

Editor overrides should operate on untyped editors only #124351

@bpasero

Description

@bpasero

Related to #106012, the editor override service ideally:

  • works on exclusively on IResourceEditorInput | IUntitledTextResourceEditorInput | IResourceDiffEditorInput

The would allow us to prevent this createEditorInput from running before the overrides are figured out:

const result = this.doResolveEditorOpenRequest(editor, optionsOrGroup, group);

(also in other places). This helps prevent leaks in editor inputs.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions