-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Closed
Labels
debtCode quality issuesCode quality issuesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insiderson-testplanworkbench-editor-resolverIssues resolving the editor inputsIssues resolving the editor inputs
Milestone
Description
Related to #106012, the editor override service ideally:
- works on exclusively on
IResourceEditorInput | IUntitledTextResourceEditorInput | IResourceDiffEditorInput
The would allow us to prevent this createEditorInput
from running before the overrides are figured out:
const result = this.doResolveEditorOpenRequest(editor, optionsOrGroup, group); |
(also in other places). This helps prevent leaks in editor inputs.
Metadata
Metadata
Assignees
Labels
debtCode quality issuesCode quality issuesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insiderson-testplanworkbench-editor-resolverIssues resolving the editor inputsIssues resolving the editor inputs