Updates to messages based on review #4018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4018 +/- ##
========================================
- Coverage 79% 56% -22%
========================================
Files 408 331 -77
Lines 19006 13969 -5037
Branches 3040 2162 -878
========================================
- Hits 14825 7702 -7123
- Misses 4179 5779 +1600
- Partials 2 488 +486
|
d3r3kk
approved these changes
Jan 16, 2019
d3r3kk
left a comment
d3r3kk
left a comment
There was a problem hiding this comment.
Sort out the tests but otherwise is fine to ship it!
karrtikr
reviewed
Jan 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4005