Send original event name when sending error event #4017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4017 +/- ##
======================================
+ Coverage 79% 79% +1%
======================================
Files 408 408
Lines 19049 19050 +1
Branches 3051 3051
======================================
+ Hits 14860 14862 +2
+ Misses 4187 4186 -1
Partials 2 2
|
d3r3kk
approved these changes
Jan 16, 2019
d3r3kk
left a comment
d3r3kk
left a comment
There was a problem hiding this comment.
Once you sort out the hygiene failure is good to go.
DonJayamanne
force-pushed
the
issueSendEventNameInErrorEvent
branch
from
a0e4ad2 to
ae17974
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.