Skip to content

Conversation

@DonJayamanne
Copy link

No description provided.

@DonJayamanne DonJayamanne added no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary labels May 6, 2024
test = []

[lib]
doctest = false
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just disables docs validation. We don't have any tests, I don't think we need to explicitly disable it. Unless it causes issues with CI runs.

@karthiknadig
Copy link
Member

We discussed offline. Move the rust test running out of nox and into its own check as "Native Tests"

@DonJayamanne DonJayamanne marked this pull request as ready for review May 6, 2024 23:13
@DonJayamanne DonJayamanne requested a review from karthiknadig May 6, 2024 23:13
@vscodenpa vscodenpa added this to the May 2024 milestone May 6, 2024
@DonJayamanne DonJayamanne merged commit 1b0c881 into native_locator May 7, 2024
@DonJayamanne DonJayamanne deleted the testing branch May 7, 2024 00:19
anthonykim1 pushed a commit to anthonykim1/vscode-python that referenced this pull request May 16, 2024
DonJayamanne added a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants