Skip to content

Conversation

@lramos15
Copy link
Member

@lramos15 lramos15 commented Dec 30, 2021

This module is important to keep up to date as new version often bring better cleaning and new features which keep the python extension aligned with VS Code core. This particular update sees a bug that caused large CPU usage fixed.

Closes #18242

@brettcannon
Copy link
Member

brettcannon commented Jan 10, 2022

It looks like the NPM package shipped a minimized JS file which is breaking Webpack. Is that intentional?

@lramos15
Copy link
Member Author

Could this have been caused by bumping to Node LTS?

@kimadeline
Copy link

Looking at the error message (ERROR in ./node_modules/vscode-extension-telemetry/lib/telemetryReporter.web.min.js 8:55451), it seems like the failing code is the e part in there: return{logEvent:(n,i)=>{e?.trackEvent({name:n}. I would guess that we don't support optional chaining.

@lramos15
Copy link
Member Author

I would guess that we don't support optional chaining

I've lowered the output to ES6 to allow this to work, 0.4.5 should pass the CI now

@brettcannon brettcannon added the no-changelog No news entry required label Jan 11, 2022
@brettcannon brettcannon merged commit fdd7b3e into main Jan 11, 2022
@brettcannon brettcannon deleted the dev/lramos15/telemetry branch January 11, 2022 19:59
@brettcannon
Copy link
Member

Thanks! That did it!

wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update vscode-extension-telemetry to 0.4.4

5 participants