fix: unify doNotSuggest #213
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
related to this conversation redhat-developer/yaml-language-server#911 (comment)
exclude doNotSuggest schema from autocompletion
doNotSuggest
was already there but implemented only for the simple object properties.This PR uses
doNotSuggest
also for other scenarios: anyOf, valuesPROBLEM
this PR contains also a fix for the test utility
testCompletionsFor
, there is an issue with checking zero suggested items.the previous implementation doesn't allow to check 'no result' with
expected: { count: 0}
but when I fixed the test utils, the test
In comment
failsOptions:
Is it tested? How?
adds unit tests