Adds baseline status to html elements and attributes #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeschli
approved these changes
Apr 23, 2025
|
Looks good! Thanks a lot @rviscomi ! |
lszomoru
approved these changes
Apr 23, 2025
| "type": "string", | ||
| "description": "Date when the feature became newly supported in all major browsers", | ||
| "pattern": "^\\d{4}-\\d{2}-\\d{2}$", | ||
| "patternErrorMessage": "Date must be in the format of `YYYY-MM-DD`" |
There was a problem hiding this comment.
I've analyzed the browsers.html-data.json file from the @vscode/web-custom-data package and found the elements with values like ≤2020-07-28 instead of just 2020-07-28 in the baseline_low_date and baseline_high_date fields.
@aeschli JFYI.
There was a problem hiding this comment.
@FluorescentHallucinogen Thanks for looking into this and catching this. Lets file this directly to against https://github.com/microsoft/vscode-custom-data
There was a problem hiding this comment.
@aeschli I've opened microsoft/vscode-custom-data#117.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on microsoft/vscode-css-languageservice#427
Similar to microsoft/vscode-css-languageservice#428, this displays baseline info in element and attribute hovercards