Skip to content

Update icons to match new VS Code style #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 9, 2019

Conversation

miguelsolorio
Copy link

VS Code is updating its icons to use an outline style. With this change coming to stable soon (should be released tomorrow), I've gone through and updated all of the icons used in the Docker extension to match this new style.

Below is a summary of the changes and a sample, I didn't touch any of the registry/azure icons as those respect those brand's icons:

image

image

cc @chrisdias @fiveisprime

@ejizba
Copy link
Contributor

ejizba commented Aug 8, 2019

Looks good! A few comments:

  1. Feels like the generic registry icon should be updated to outline style somehow. The easiest way to reproduce is actually to change the "Group By" in the images view to "Registry".
    Screen Shot 2019-08-08 at 10 01 26 AM
    Screen Shot 2019-08-08 at 10 02 42 AM
  2. Should the clipboard icon for tasks remove its color? Seems like color is only used for things like status and in brand icons. Also note there's actually two separate clipboard icons:
    Screen Shot 2019-08-08 at 10 08 48 AM
  3. Is the tag icon standard or used elsewhere? If not - can we get rid of the "string" going through the tag? My biggest complaint about the outline style is it makes complex icons more difficult to see. The original icon shape felt simpler:
    Screen Shot 2019-08-08 at 10 18 52 AM
  4. The "play" and "stop" icons got rid of the enclosing circle (which I think I prefer). Should the "checkmark", "error" and "pause" icons also get rid of the enclosing circle?
    Screen Shot 2019-08-08 at 10 19 31 AM

@miguelsolorio
Copy link
Author

miguelsolorio commented Aug 9, 2019

@EricJizbaMSFT thanks for the feedback, I went ahead and updated the icons based on your feedback, let me know what you think. Not sure if the new registry icons works. I also left the Error/Warning in their circle/triangle to be consistent with our icons.

image

@ejizba
Copy link
Contributor

ejizba commented Aug 9, 2019

Much better thanks! Although a few of the new ones seem to have a white background problem on light theme...
Screen Shot 2019-08-09 at 10 29 36 AMScreen Shot 2019-08-09 at 10 29 41 AMScreen Shot 2019-08-09 at 10 30 00 AM

@miguelsolorio
Copy link
Author

Sorry about, I removed the white background on all of them.

image

Copy link
Contributor

@ejizba ejizba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@ejizba ejizba merged commit 76772d8 into microsoft:master Aug 9, 2019
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants