Extension does not correctly handle WSL symlinks

[schwarzichet]

Type: LanguageService

Describe the bug

• OS and Version: 1803
• WSL version: Ubuntu 18.04
• VS Code Version: 1.24.1
• C/C++ Extension Version: 0.17.4
• Other extensions you installed (and if the issue persists after disabling them):
• A clear and concise description of what the bug is.
  I want to include LLVM in a project but vscode-cpptools seems to fail to intellisense.

To Reproduce
Steps to reproduce the behavior:
c_cpp_prperties.json

{
    "configurations": [
        {
            "name": "WSL",
            "intelliSenseMode": "clang-x64",
            "compilerPath": "/usr/bin/gcc",
            "includePath": [
                "${workspaceFolder}",
                "/mnt/c/libraries/lib1/include",
                "C:/libraries/lib2/include"
            ],
            "defines": [],
            "browse": {
                "path": [
                    "${workspaceFolder}",
                    "/mnt/c/libraries"
                ],
                "limitSymbolsToIncludedHeaders": true,
                "databaseFilename": ""
            },
            "cStandard": "c11",
            "cppStandard": "c++17"
        }
    ],
    "version": 4
}

edit an C/C++ source code file and try to type this

#include <llvm/IR/Module.h>

Expected behavior
show no error read lines and make correct intellisense

Screenshots

Additional context
it seems that the extension do find the LLVM folder but somehow it cannot recognize it. I tried to make a soft link named "llvm" for "llvm-6.0" in /usr/include/ but it is useless.

[bobbrow]

Where does llvm live on your PC? Do you have a C:\libraries folder on your PC, or is that configuration just the value copied from the documentation? You should add the path to the llvm folder in your configuration browse.path and includePath if you want it to show up in IntelliSense.

[schwarzichet]

well, I just figured out that "/mnt/c/libraries/lib1/include" means you should replace it with your library path. Now it works with such a configuration

{
    "configurations": [
        {
            "name": "WSL",
            "intelliSenseMode": "clang-x64",
            "compilerPath": "/usr/bin/gcc",
            "includePath": [
                "${workspaceFolder}",
                "/usr/include/llvm-6.0",
                "/usr/include/llvm-c-6.0"
            ],
            "defines": [],
            "browse": {
                "path": [
                    "${workspaceFolder}",
                    "/usr/include/llvm-6.0",
                    "/usr/include/llvm-c-6.0"
                ],
                "limitSymbolsToIncludedHeaders": true,
                "databaseFilename": ""
            },
            "cStandard": "c11",
            "cppStandard": "c++17"
        }
    ],
    "version": 4
}

But I wonder why the soft link fails. I do make the soft link but it fails when I set the c_cpp_properties.json as

{
    "configurations": [
        {
            "name": "WSL",
            "intelliSenseMode": "clang-x64",
            "compilerPath": "/usr/bin/gcc",
            "includePath": [
                "${workspaceFolder}",
                "/usr/include/llvm",
                "/usr/include/llvm-c"
            ],
            "defines": [],
            "browse": {
                "path": [
                    "${workspaceFolder}",
                    "/usr/include/llvm",
                    "/usr/include/llvm-c"
                ],
                "limitSymbolsToIncludedHeaders": true,
                "databaseFilename": ""
            },
            "cStandard": "c11",
            "cppStandard": "c++17"
        }
    ],
    "version": 4
}

Does it have something to do with
microsoft/WSL#1475

[bobbrow]

It could. But we haven't done any testing of WSL symlinks in the Windows environment (where VS Code runs). We can use this issue to track that.

[sean-mcmanus]

Oh, this is a bug with #include completion not treating symlinks as directories. We correctly resolve the symlinks in the includePath so the header is found by IntelliSense (no green squiggle), right?