Fix host.json version not showing for AzureExtensionsBundle #4622
Conversation
There was a problem hiding this comment.
This is a solid fix for issue #4594! The nullish coalescing operator appropriately handles the case where getLatestVersionRange() returns null/undefined, ensuring that extension bundles always get a valid version in host.json.
The change is minimal, targeted, and preserves the existing error handling while adding the necessary null safety. This should resolve the Python timer trigger project creation issue.
One minor consideration is whether the function signature should be updated to reflect that it can return null/undefined, but the fix itself is correct and ready for merge.
| @@ -90,7 +90,7 @@ export namespace bundleFeedUtils { | |||
| export async function addDefaultBundle(context: IActionContext, hostJson: IHostJsonV2): Promise<void> { | |||
| let versionRange: string; | |||
| try { | |||
| versionRange = await getLatestVersionRange(context); | |||
| versionRange = (await getLatestVersionRange(context)) ?? defaultVersionRange; | |||
There was a problem hiding this comment.
Good fix for null/undefined handling! This change correctly addresses the issue described in #4594 where getLatestVersionRange() can return null or undefined, causing the extension bundle version to be missing from host.json.
The nullish coalescing operator (??) is the right solution here because:
- It handles both
nullandundefinedreturn values fromgetLatestVersionRange() - It falls back to
defaultVersionRangewhich ensures the extension bundle gets a valid version - It's more precise than the existing try/catch block since it only handles the null/undefined case, not all possible errors
This should fix the Python timer trigger project creation issue where host.json was missing the version property in extensionBundle.
Review generated with Copilot
|
Thanks for your contribution! This will be in our next release ❤️ |
Fixes #4594
Added a nullish coalescing operator to take care of the case when the returned value is
nullorundefined. Changing thegetLatestVersionRangeto throw error didn't make sense as it is just for trying to get the latest version. It's fine if the latest version cannot be retreived and the function returns null.