Skip to content

Conversation

d-s-dc
Copy link
Contributor

@d-s-dc d-s-dc commented Jun 26, 2025

Problem

In advanced Function App creation, the wizard always prompts for a User Assigned Identity, even when secret-based access is used and no identity is needed.

Fix

promptSteps.push(new UserAssignedIdentityListStep()); would prompt for user-assigned identity regardless of the access method specified. It is not needed as it is already inside promptSteps.push(new AuthenticationPromptStep()) (at line 72).

Testing

  • Tested the function app creation for both advanced and default mode. No breaks and access method specified is respected.
  • Ran npm test successfully.

@d-s-dc d-s-dc requested a review from a team as a code owner June 26, 2025 00:18
Copy link
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Tested it out and seems to work fine. As mentioned, the AuthentcationPromptStep will add the subwizard accordingly, so we didn't need to leave add the prompt step in createCreateFunctionAppComponents.

@nturinski nturinski enabled auto-merge (squash) June 26, 2025 16:45
@nturinski nturinski merged commit cd1f497 into microsoft:main Jun 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants