Skip to content

Set templateSchemaVersion regardless if prompt is skipped #4295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Set templateSchemaVersion regardless if prompt is skipped #4295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/commands/createNewProject/NewProjectLanguageStep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,12 @@ export class NewProjectLanguageStep extends AzureWizardPromptStep<IProjectWizard
throw new UserCancelledError('viewSampleProjects');
} else {
context.language = result.language;
// TODO: Probably should include a ProgrammingModelStep for all languages and set there. but for now we know if it's not Python, there's no way it'll be v2
if (result.language !== ProjectLanguage.Python) {
context.templateSchemaVersion = TemplateSchemaVersion.v1;
}
this.setTemplateSchemaVersion(context);
}
}

public shouldPrompt(context: IProjectWizardContext): boolean {
this.setTemplateSchemaVersion(context);
return context.language === undefined;
}

Expand Down Expand Up @@ -145,4 +143,11 @@ export class NewProjectLanguageStep extends AzureWizardPromptStep<IProjectWizard

return wizardOptions;
}

private setTemplateSchemaVersion(context: IProjectWizardContext): void {
// TODO: Probably should include a ProgrammingModelStep for all languages and set there. but for now we know if it's not Python, there's no way it'll be v2
if (context.language && context.language !== ProjectLanguage.Python) {
context.templateSchemaVersion = TemplateSchemaVersion.v1;
}
}
}
Loading