Fix creating a function app with no workspace open #4061
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturinski
approved these changes
Mar 28, 2024
nturinski
reviewed
Mar 28, 2024
| @@ -20,7 +20,7 @@ export async function detectDockerfile(context: ICreateFunctionAppContext): Prom | |||
| context.rootPath = workspacePath; | |||
|
|
|||
| //check for host.json location | |||
| if (!(await isFunctionProject(workspacePath))) { | |||
| if (await isFunctionProject(workspacePath)) { | |||
| const files = (await findFiles(context.workspaceFolder, `*/${hostFileName}`)); | |||
| if (files.length === 0) { | |||
There was a problem hiding this comment.
You honestly probably don't need these checks anymore either.
There was a problem hiding this comment.
Talked offline and the checks are still needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking telemetry today and noticed the error count was a little high for the create function app telemetry event. Looking further into we were blocking users from creating a function app when no workspace was open. This happened due to the containerized function app flow checking for a dockerfile in the workspace. I added a check to see if a workspace was open before running this step which should fix that issue.