Skip to content

Conversation

cbezault
Copy link
Contributor

@cbezault cbezault commented Jan 8, 2020

When searching for visual studio toolchain files which can satisfy the host, target pair of {ARM, ARM64} X {x86, x64, arm, arm64} we should allow the x86_{x86, x64, arm, arm64} toolchain files to be selected because of the Windows x86 emulation on ARM.

@cbezault cbezault changed the title [vcpkg] Mark ARM and x86 on ARM64 and x86 on ARM as supported architectures [vcpkg] Mark ARM and x86 on ARM64 and x86 on ARM as supported architectures on Windows Jan 8, 2020
@cbezault cbezault changed the title [vcpkg] Mark ARM and x86 on ARM64 and x86 on ARM as supported architectures on Windows [vcpkg] Mark ARM and x86 on ARM64 and x86 on ARM as supported architectures for Windows Jan 8, 2020
@cbezault cbezault changed the title [vcpkg] Mark ARM and x86 on ARM64 and x86 on ARM as supported architectures for Windows [vcpkg] Mark ARM and x86 on ARM64 and x86 on ARM as supported architectures when searching for toolchains on Windows Jan 8, 2020
@JackBoosY JackBoosY self-assigned this Jan 8, 2020
@JackBoosY JackBoosY self-requested a review January 8, 2020 03:05
@cbezault
Copy link
Contributor Author

cbezault commented Jan 8, 2020

/azp run

3 similar comments
@cbezault
Copy link
Contributor Author

cbezault commented Jan 8, 2020

/azp run

@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 9, 2020

/azp run

@cbezault
Copy link
Contributor Author

cbezault commented Jan 9, 2020

/azp run

@vicroms
Copy link
Member

vicroms commented Jan 9, 2020

LGTM

@vicroms vicroms merged commit 7b61b7b into microsoft:master Jan 9, 2020
@cbezault
Copy link
Contributor Author

Resolves #9439

strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants