Skip to content

Conversation

vbaderks
Copy link
Contributor

Upgrade to the latest released version of CharLS.

Note: The patch file has become obsolete.

The following triplets are supported:
charls:x86-windows
charls:x86-windows-static
charls:x64-windows
charls:x64-windows-static
charls:x64-uwp
charls:x64-linux
charls:x64-osx

Upgrade to the latest released version of CharLS. The patch file has become obsolete.
@msftclas
Copy link

msftclas commented Dec 29, 2019

CLA assistant check
All CLA requirements met.

@JackBoosY JackBoosY self-assigned this Dec 30, 2019
@JackBoosY JackBoosY self-requested a review December 30, 2019 03:09
@vbaderks vbaderks marked this pull request as ready for review December 30, 2019 08:45
@vbaderks
Copy link
Contributor Author

Note: the CI checks are currently failing/pending. This seems to be caused by other changes and the problem with the macOS pipeline.

Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove these following code in VCPKG_PATH/scripts/ci.baseline.txt ?

charls:arm-uwp=fail
charls:x64-uwp=fail

Both arm-uwp and x64-uwp can be build.
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 30, 2019
@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 2, 2020

/azp run

@dan-shaw dan-shaw merged commit 8b07958 into microsoft:master Jan 2, 2020
@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 2, 2020

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants