Skip to content

[argumentum] Add new port #9478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 2, 2020
Merged

[argumentum] Add new port #9478

merged 11 commits into from
Jan 2, 2020

Conversation

mmahnic
Copy link
Contributor

@mmahnic mmahnic commented Dec 27, 2019

Argumentum is a library for parsing command line arguments. It can be used as a static library and as a header-only library. A dynamic version is planned for a future release.

What does your PR fix? It adds a new port.

Which triplets are supported/not supported? Have you updated the CI baseline?
Tested only on x64-linux.

Does your PR follow the maintainer guide?
I believe so.

@mmahnic mmahnic mentioned this pull request Dec 27, 2019
Closed
@mmahnic mmahnic changed the title [argumentum] Add argumentum [argumentum] Add new port Dec 28, 2019
NancyLi1013
NancyLi1013 suggested changes Dec 30, 2019
View reviewed changes
@NancyLi1013
Copy link
Contributor

Hi @mmahnic thanks for this PR.
I noticed that this port failed on arm-uwp, x64-uwp, arm64-windows.
Are those expected? If this port currently doesn't support arm, arm64, uwp, please add this to portfile.cmake.

vcpkg_fail_port_install(ON_ARCH "arm" "arm64" ON_TARGET "uwp")
Besides this, please also update ci.baseline.txt with the following content:

argumentum:arm4-windows=fail
argumentum:x64-uwp=fail
argumentum:arm-uwp=fail

If not, please try to fix the failures.

@mmahnic mmahnic requested a review from NancyLi1013 December 31, 2019 18:35
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jan 2, 2020
@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 2, 2020

/azp run

@dan-shaw dan-shaw merged commit 6403c56 into microsoft:master Jan 2, 2020
@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 2, 2020

Thanks for the PR!

@mmahnic mmahnic deleted the add_argumentum branch January 3, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@NancyLi1013 NancyLi1013

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmahnic @NancyLi1013 @dan-shaw