Skip to content

[azure-kinect-sensor-sdk] Remove feature test and fix static build in Windows #9458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 10, 2020
Merged

[azure-kinect-sensor-sdk] Remove feature test and fix static build in Windows #9458

merged 5 commits into from
Jan 10, 2020

Conversation

JackBoosY
Copy link
Contributor

  • Remove feature test due to we don't need it.
  • Fix windows-static build failure: cannot find PYTHON3

Related: #9457.

Note: feature tool will fix after #8788 merge, other feature tested successfully in the following triplets:

  • x86-windows
  • x86-windows-static
  • x64-windows
  • x64-linux

@NancyLi1013 NancyLi1013 mentioned this pull request Dec 27, 2019
Merged
@JackBoosY JackBoosY changed the title [azure-kinect-sensor] Remove feature test and fix static build in Windows [azure-kinect-sensor-sdk] Remove feature test and fix static build in Windows Dec 30, 2019
@JackBoosY
Copy link
Contributor Author

@vicroms In x86-windows:

CMake Error: Could not open file for write in copy operation C:/vsts/_work/3/s/buildtrees/azure-kinect-sensor-sdk/src/11aa54ede6-301103fcfa/src/csharp/VersionInfo.cs.tmp
CMake Error: : System Error: Permission denied
CMake Error at CMakeLists.txt:303 (configure_file):
  configure_file Problem configuring file

Could you have a look?

Thanks.

@JackBoosY JackBoosY marked this pull request as ready for review December 31, 2019 02:57
@JackBoosY JackBoosY requested a review from PhoebeHui December 31, 2019 02:57
@PhoebeHui
Copy link
Contributor

/azp run

@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 7, 2020

/azp run

@PhoebeHui
Copy link
Contributor

/azp run

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jan 10, 2020
@dan-shaw dan-shaw merged commit 7dc8ecb into microsoft:master Jan 10, 2020
@JackBoosY JackBoosY deleted the dev/jack/9457 branch January 11, 2020 03:48
This was referenced Jan 13, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackBoosY @PhoebeHui @dan-shaw