Skip to content

[asiosdk] Add new port #9456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 27, 2020
Merged

[asiosdk] Add new port #9456

merged 4 commits into from
Jan 27, 2020

Conversation

batlogic
Copy link
Contributor

@batlogic batlogic commented Dec 27, 2019 •
edited
Loading

This adds the new package asiosdk (Steinberg's ASIO SDK library support ).

  • What does your PR fix? Fixes issue #
    no fixes as this is a new port.

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    tested with x64 and win32, simple header only interface library. by nature the ASIO SDK is a Windows only library.

  • Does your PR follow the [maintainer guide]
    I believe so.

@msftclas
Copy link

msftclas commented Dec 27, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@JackBoosY JackBoosY self-assigned this Dec 28, 2019
@JackBoosY JackBoosY self-requested a review December 28, 2019 11:01
@JackBoosY
Copy link
Contributor

/azp run

JackBoosY
JackBoosY suggested changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this port doesn't support UNIX, please add the following code to VCPKG_PATH/scripts/ci.baseline.txt :

asiosdk:x64-liinux=fail
asiosdk:x64-osx=fail

@batlogic batlogic requested a review from JackBoosY January 3, 2020 12:02
@JackBoosY JackBoosY requested a review from PhoebeHui January 6, 2020 02:28
@JackBoosY
Copy link
Contributor

/azp run

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 16, 2020
@batlogic
Copy link
Contributor Author

batlogic commented Jan 19, 2020 •
edited
Loading

this port has been sitting in limbo for over three weeks, looks like it's been due of the osx tests failing...
is there something I can do to move the process along?

image

@JackBoosY
Copy link
Contributor

@batlogic vcpkg-osx-PR is deprecated, please ignore it.

@vicroms vicroms merged commit 6ab471d into microsoft:master Jan 27, 2020
@vicroms
Copy link
Member

vicroms commented Jan 27, 2020

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui Awaiting requested review from PhoebeHui

1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@JackBoosY JackBoosY

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@batlogic @msftclas @JackBoosY @vicroms