Skip to content

[sdl2-gfx] Fixed build error ARM64 Windows 10 #9314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 27, 2020
Merged

[sdl2-gfx] Fixed build error ARM64 Windows 10 #9314

merged 8 commits into from
Jan 27, 2020
+29 −2

Conversation

shibayan
Copy link
Contributor

Fixed ARM64 build error:

  • Add lrint function for ARM64 (tested on Surface Pro X)
  • Update ci.baseline.txt

@PhoebeHui PhoebeHui requested a review from JackBoosY December 16, 2019 02:48
@JackBoosY
Copy link
Contributor

We want upstream to merge these changes in order to reduce the amount of maintenance code. Can you submit a PR to upstream?

Thanks.

@JackBoosY
Copy link
Contributor

JackBoosY commented Dec 16, 2019 •
edited
Loading

Can you open a new issue in vcpkg to describe this bug?

Thanks.

@shibayan
Copy link
Contributor Author

Thanks. From now on, I will open an issue before creating a PR.

@shibayan shibayan mentioned this pull request Dec 16, 2019
Closed
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 17, 2019
@JackBoosY
Copy link
Contributor

Can you resolve these conflicts?

Thanks.

@JackBoosY JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label Jan 7, 2020
@shibayan
Copy link
Contributor Author

shibayan commented Jan 7, 2020

I resolved conflicts. thanks!

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 8, 2020
@JackBoosY
Copy link
Contributor

/azp run

@JackBoosY JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label Jan 17, 2020
@JackBoosY
Copy link
Contributor

@shibayan Can you revert changes to the baseline and make changes again?

Thanks.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 17, 2020
@JackBoosY
Copy link
Contributor

LGTM, thanks for this PR!

@vicroms vicroms merged commit 268d7bb into microsoft:master Jan 27, 2020
@shibayan shibayan deleted the sdl2-gfx-arm64 branch February 1, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@JackBoosY JackBoosY

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shibayan @JackBoosY @vicroms @dan-shaw