[faad2] Add initial version of FAAD2 #9003
Conversation
janisozaur
force-pushed
the
faad2
branch
2 times, most recently
from
420e966 to
16ab16b
Compare
|
ping @knik0 @fabiangreffrath All the attached patches were merged as: I added a comment to each of the patches with link to pull request. |
|
/azp run |
|
Hi @janisozaur thanks for this PR. If not, please try to fix it. Thnaks. |
|
I've updated the port. with your suggestions. I don't intend to target Linux and OSX with this port, but would like to know if there is a way to extract logs of AZP containing failure messages? |
|
@janisozaur thanks for your updates.
After you click If this port failed due to
Hope this help you some. |
|
Needless to say that FAAD2 builds perfectly fine on Debian and any other Linux distribution. |
FAAD2 lists its homepage as https://sourceforge.net/projects/faac/, but it links to https://github.com/knik0/faad2 as the place to send pull requests. This seems good enough for Debian[0] and Arch[1], and the SF hosts only a bit older versions, so I used the GitHub project as well. Note that though the project is named "faad2", the library name is just "faad" The embedded patches were all submitted and already merged upstream. [0] https://packages.debian.org/sid/faad [1] https://www.archlinux.org/packages/extra/x86_64/faad2/
|
As I mentioned earlier, supporting Linux and OS X with this vcpkg is not my goal and I chose to explicitly disable it, as requested. I'm mostly interested in having a sane package manager for Windows and all Windows triplets should now be supported. |
|
This LGTM, thanks for the PR @janisozaur! @fabiangreffrath We don't require initial submitters to support every platform possible; if you'd like to make a PR to enable Linux and OSX that would be awesome! |
|
Sorry, but I am just the Debian maintainer for faad2 and don't have any plans to also get involved here. |
FAAD2 lists its homepage as https://sourceforge.net/projects/faac/, but
it links to https://github.com/knik0/faad2 as the place to send pull
requests. This seems good enough for Debian[0] and Arch[1], and the SF
hosts only a bit older versions, so I used the GitHub project as well.
Note that though the project is named "faad2", the library name is just
"faad"
[0] https://packages.debian.org/sid/faad
[1] https://www.archlinux.org/packages/extra/x86_64/faad2/