Skip to content

Conversation

zi-m
Copy link
Contributor

@zi-m zi-m commented Oct 20, 2019

https://github.com/OGRECave/ogre-next
# This portfile is based (shamelessly copied and adapted a bit) on 'ogre' portfile.

@zi-m zi-m marked this pull request as ready for review October 20, 2019 23:43
@vicroms vicroms self-assigned this Oct 23, 2019
@traversaro
Copy link
Contributor

Would it make sense to call the port ogre2, that seems to be more informative of the vague ogre-next ? This is the same solution used in other repos such as Arch https://aur-dev.archlinux.org/packages/ogre-2.0/ or custom homebrew in https://github.com/osrf/homebrew-simulation/blob/master/Aliases/ogre2 .

By the way, a custom ogre2 port is available at https://github.com/osrf/vcpkg-ports/tree/master/ogre2 , I do not know if it can be useful for you as reference.

cc @j-rivero

@j-rivero
Copy link

Would it make sense to call the port ogre2, that seems to be more informative of the vague ogre-next ?

+1 to call it ogre2. The Ogre projects published some weeks ago the official split between the two projects.

By the way, a custom ogre2 port is available at https://github.com/osrf/vcpkg-ports/tree/master/ogre2 , I do not know if it can be useful for you as reference.

Our port probably lacks of many features needed for going official, take it with caution. The main goal for us was to get an ogre2 port that was able to be installed side-by-side with ogre1 (we maintain different libraries that has support for both).

@traversaro
Copy link
Contributor

+1 to call it ogre2. The Ogre projects published some weeks ago the official split between the two projects.

Thanks for the link, I just noticed that there they mention that:

This also makes it possible to follow semver with Ogre1 and make a 2.0 release when needed.

If there is the possibility in the future of having ogre v2.0 and ogre2 inside vcpkg, that would be quite confusing, and it is something that would suggest that ogre-next is a better name. By the way in https://www.ogre3d.org/2019/09/15/ogre-ecosystem-roundup-3 they call the new version ogre-next, and they call it ogre-next also in https://www.ogre3d.org/about/what-version-to-choose . So perhaps ogre-next is indeed the best name for the port.

@j-rivero
Copy link

So perhaps ogre-next is indeed the best name for the port.

Sounds reasonable to me. I don't have anything strong against it.

@zi-m zi-m requested a review from vicroms October 28, 2019 20:35
@PhoebeHui PhoebeHui self-requested a review October 29, 2019 02:35
@PhoebeHui
Copy link
Contributor

PhoebeHui commented Oct 31, 2019

@zi-m, thanks for the PR!
The CI system doesn't test ogre-next features, I tested them manually, csharp, java and python build successfully. However, d3d9 failed. could you help have a look?

./vcpkg install ogre-next[d3d9]:x64-windows
Failed in cmake configure step. Failures:H
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
DirectX9_D3DX9_LIBRARY (ADVANCED)
linked by target "RenderSystem_Direct3D9" in directory F:/VCPKG/8677/vcpkg/buildtrees/ogre-next/src/c710e36bc0-9cfa542442/RenderSystems/Direct3D9

@zi-m
Copy link
Contributor Author

zi-m commented Nov 1, 2019

@zi-m, thanks for the PR!
The CI system doesn't test ogre-next features, I tested them manually, csharp, java and python build successfully. However, d3d9 failed. could you help have a look?

@PhoebeHui
I added environment-overrides.cmake and instructions:

Building steps for ogre-next[d3d9]:

1. Download and install "Microsoft DirectX SDK"
https://www.microsoft.com/en-us/download/confirmation.aspx?id=6812

2. Set env variable
set DXSDK_DIR=C:/Program Files (x86)/Microsoft DirectX SDK (June 2010)

3. Install port
.\vcpkg.exe install ogre-next[d3d9] --triplet x64-windows

@vicroms
Copy link
Member

vicroms commented Nov 1, 2019

Thanks for the PR!

@vicroms vicroms merged commit 9bf809b into microsoft:master Nov 1, 2019
@zi-m zi-m deleted the ogre-next branch November 1, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants