Skip to content

[opencc] Add new port #8474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 28, 2020
Merged

[opencc] Add new port #8474

merged 15 commits into from
Apr 28, 2020

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Oct 7, 2019

Fix #7347 .

@myd7349 myd7349 marked this pull request as ready for review October 7, 2019 07:53
@myd7349
Copy link
Contributor Author

myd7349 commented Oct 7, 2019

BYVoid/OpenCC#350

vicroms
vicroms requested changes Oct 9, 2019
View reviewed changes
@vicroms vicroms self-assigned this Oct 9, 2019
@JackBoosY
Copy link
Contributor

/azp run

LilyWangL
LilyWangL suggested changes Jan 21, 2020
View reviewed changes
@JackBoosY
Copy link
Contributor

Seems build failure on arm/uwp, can you check that?

Thanks.

@LilyWangL
Copy link
Contributor

Pinging @myd7349 for response. Is work still being done for this PR?

@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Apr 28, 2020
@strega-nil
Copy link
Contributor

Alright, this looks good! Thanks @myd7349 :)

@strega-nil strega-nil merged commit b9c3a26 into microsoft:master Apr 28, 2020
@myd7349 myd7349 deleted the prs/opencc branch April 29, 2020 00:45
@BillyONeal BillyONeal mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms requested changes

+1 more reviewer

@LilyWangL LilyWangL LilyWangL approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@vicroms vicroms

@LilyWangL LilyWangL

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Port Request] OpenCC
5 participants
@myd7349 @JackBoosY @LilyWangL @strega-nil @vicroms