Skip to content

[mgnlibs] Add new port #8390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2019
Merged

[mgnlibs] Add new port #8390

merged 1 commit into from
Oct 3, 2019

Conversation

g-e-n-o-s
Copy link
Contributor

This is a redo of #7657

Now copies header files to include/mgnlibs instead of include

@Rastaban Rastaban self-assigned this Sep 30, 2019
@cbezault
Copy link
Contributor

Do downstream consumers expect the headers to be in include/mgnlibs?

@g-e-n-o-s
Copy link
Contributor Author

Probably not. They would have to edit their CMake configurations to check for mgnlibs in PATH_SUFFIXES, or as a vcpkg port, they would have to be patched.

(Brought up in #7657 was that these header files have common names. For example, ini.h conflicts with the inih port.)

@Rastaban Rastaban merged commit f89462c into microsoft:master Oct 3, 2019
@g-e-n-o-s g-e-n-o-s deleted the mgnlibs branch October 3, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Rastaban Rastaban Rastaban approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Rastaban Rastaban

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g-e-n-o-s @cbezault @Rastaban