[libsoundio] Add libsoundio port #8273
Merged
+347
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rastaban
reviewed
Sep 20, 2019
|
Do you know if the library supports UWP? If not we can ignore those failures in the CI system. |
|
@Rastaban Probably, This library is not supports UWP. We should be ignore UWP tests in CI. |
Rastaban
approved these changes
Sep 20, 2019
UnaNancyOwen
force-pushed
the
add_libsoundio
branch
from
6424335 to
7760f52
Compare
UnaNancyOwen
force-pushed
the
add_libsoundio
branch
from
001a116 to
9c3e62a
Compare
|
@Rastaban I was finished some fixes about libsoundio-config.cmake. It works correctly on Windows and Linux (Ubuntu 18.04 LTS). |
|
LGTM, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add libsoundio.