Fix build with Emscripten/WASM #7948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCRE does not support Just-in-time compilation when targeting WebAssembly.
|
Cool, I assume then that you're a user of a custom Emscripten toolchain/triplet? |
|
Yes, I’m using a custom triplet.
Upstream emacripten / cmake use “Emscripten” as System name.
…On Wed 28. Aug 2019 at 19:13, Curtis J Bezault ***@***.***> wrote:
Cool, I assume then that you're a user of a custom Emscripten
toolchain/triplet?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7948?email_source=notifications&email_token=AAAALTQGWJ5BOXTADOY26L3QG2W3ZA5CNFSM4IRNA33KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5L2LEA#issuecomment-525837712>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAALTQWYYG4XTVJN5AZTS3QG2W3ZANCNFSM4IRNA33A>
.
|
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCRE does not support Just-in-time compilation when targeting
WebAssembly.