Skip to content

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Jul 21, 2019

@myd7349
Copy link
Contributor Author

myd7349 commented Jul 21, 2019

Known issue:
Because of the layout of installed header files(foonathan/memory#23), in a CMake project, the users may include the header files like this:

#include <foonathan/memory/memory_pool.hpp>

but in a MSBuild project, it has to be:

#include <foonathan_memory/foonathan/memory/memory_pool.hpp>

Update: Fixed!

@myd7349 myd7349 marked this pull request as ready for review July 21, 2019 09:29
@myd7349
Copy link
Contributor Author

myd7349 commented Jul 21, 2019

Known issue:
https://github.com/myd7349/Ongoing-Study/tree/master/cpp/CMake/vcpkg/foonathan-memory-example
Runtime error: Segmentation fault (core dumped)

@cbezault cbezault self-assigned this Aug 27, 2019
@ras0219-msft
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cbezault cbezault merged commit b0282fe into microsoft:master Sep 17, 2019
@myd7349 myd7349 deleted the foonathan-memory-init branch September 20, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants