Skip to content

[argus] New port at version 0.1.0 #46296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2025
Merged

Conversation

lucocozz
Copy link
Contributor

@lucocozz lucocozz commented Jul 5, 2025

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@lucocozz lucocozz force-pushed the new_port/argus branch 5 times, most recently from adc0b96 to 1b0180d Compare July 5, 2025 15:10
@vicroms vicroms marked this pull request as draft July 5, 2025 19:31
@vicroms vicroms self-assigned this Jul 5, 2025
@vicroms vicroms added category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines labels Jul 5, 2025
@lucocozz lucocozz force-pushed the new_port/argus branch 2 times, most recently from d75fab6 to e3da111 Compare July 6, 2025 13:11
@vicroms vicroms added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jul 8, 2025
@@ -0,0 +1,22 @@
{
"name": "argus",
Copy link
Member

@vicroms vicroms Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ras0219-msft @BillyONeal and @vicroms

The current name conflicts with openargus using our naming guidelines of removing common prefixes/suffixes like open-, lib-, cpp-, etc.

However, we acknowledge that openargus is not a library and searching for "argus argument parsing in C" does show this library as the top result in Bing. There's also other existing argument parsing libraries with the same name (https://github.com/whexy/Argus, https://github.com/KageKirin/argus) which could lead to confusion for users.

We don't consider this a blocker, but we think your users would feel a lot better if, it had the GitHub org name prefix lucocozz-argus.

@vicroms vicroms removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jul 17, 2025
@vicroms vicroms marked this pull request as ready for review July 17, 2025 19:59
@vicroms vicroms merged commit 5d843dd into microsoft:master Jul 20, 2025
18 checks passed
talregev pushed a commit to talregev/vcpkg that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants