-
Notifications
You must be signed in to change notification settings - Fork 7k
[syscalls-cpp] Add new port #45996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[syscalls-cpp] Add new port #45996
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to take names which are likely to conflict with other packages or users, like <crt.h>
or <hash.h>
. Can they be installed into a subdirectory instead?
yes, the current version supports x86, I'll pull the port now and fix the file name collision |
@BillyONeal everything normal now |
Usage passed on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @LilyWangLL
Co-authored-by: Lily Wang <[email protected]>
Co-authored-by: Lily Wang <[email protected]>
the tests failed even though nothing related to hashes was touched? |
fixed @BillyONeal |
@LilyWangLL Can you look at this again? |
@sapdragon Thanks for the port! @LilyWangLL Thanks for the review! |
Co-authored-by: Lily Wang <[email protected]>
This PR adds a new port for
syscalls-cpp
, a header-only C++ library for making direct syscalls on Windows x64. It uses a policy-based design for flexibility in memory allocation, stub generation, and syscall parsing.find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx. (N/A, no dependencies)vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.