[yalantinglibs] Add a new port

[171930433]

No description provided.

[jimwang118]

I will convert this PR to a draft. After all CIs are green, you can click "ready for review".

[171930433]

@171930433 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

[171930433]

@microsoft-github-policy-service agree

[171930433]

I have already replied to the CLA, but why did all the CIs fail?
@jimwang118 @dg0yt

[dg0yt]

why did all the CIs fail?

Looks like a temporary connectivity issue.

Let me add some comments.

[dg0yt]

FTR upstream has zero external usage/stars/contributors.

[dg0yt]

This description is a vague description of what users could expect.

[171930433]

Platform Android is not yet supported by yalantinglibs . Could you please help me check why the x86_windows build failed? @dg0yt

[poor-circle]

the dependence is loss, asio, frozen and
async_simple should add

[jimwang118]

Usage test passed with x64-windows triplet.

[poor-circle]

we need add option INSTALL_THIRDPARTY=OFF
, and install them by vcpkg

[171930433]

we need add option INSTALL_THIRDPARTY=OFF , and install them by vcpkg

目前yalantinglibs在vcpkg这边使用的还是我fork的仓库，因为需要alibaba/yalantinglibs打一个tag，

1. “the dependence is loss, asio, frozen and async_simple should add”， 这个没太理解我需要怎么操作
2. “we need add option INSTALL_THIRDPARTY=OFF , and install them by vcpkg”， 这个明确

这些改动可以等到alibaba/yalantinglibs打一个tag时， 一起修改

[poor-circle]

1. 这个没太理解我需要怎么操作

we need add option INSTALL_THIRDPARTY=OFF , and install them by vcpkg

目前yalantinglibs在vcpkg这边使用的还是我fork的仓库，因为需要alibaba/yalantinglibs打一个tag，

1. “the dependence is loss, asio, frozen and async_simple should add”， 这个没太理解我需要怎么操作
2. “we need add option INSTALL_THIRDPARTY=OFF , and install them by vcpkg”， 这个明确

这些改动可以等到alibaba/yalantinglibs打一个tag时， 一起修改

你看下我的review，tag也加了，最新版本0.3.10，你可以切到这个版本。

[BillyONeal]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[171930433]

@poor-circle @dg0yt @jimwang118 all ci passed

[BillyONeal]

• Changes comply with the maintainer guide.

• The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.

• Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.

  There appear to be a number of unguarded optional dependencies here:

  src\easylog\benchmark\CMakeLists.txt

  find_package(glog QUIET)
  find_package(spdlog QUIET)
  

  src\struct_pack\benchmark\CMakeLists.txt

  find_package(Protobuf QUIET)
  find_package(Flatbuffers QUIET)
  

  These are probably fine because tests are turned off:

  src\coro_http\tests\CMakeLists.txt

  find_package(ZLIB)
  

  src\struct_pb\tests\CMakeLists.txt

  find_package(Protobuf QUIET)
  

  These are probably fine because examples are turned off:

  src\coro_rpc\examples\user_defined_rpc_protocol\rest_rpc\CMakeLists.txt

  find_package(Msgpack)
  

• The versioning scheme in vcpkg.json matches what upstream says.

• The license declaration in vcpkg.json matches what upstream says.

• The installed as the "copyright" file matches what upstream says.

• The source code of the component installed comes from an authoritative source.

• The generated "usage text" is accurate. See adding-usage for context.

• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.

• Only one version is in the new port's versions file.

• Only one version is added to each modified port's versions file.

[BillyONeal]

Can you describe why the potentially optional dependencies are missing above, or fix them to be explicitly disabled or included in vcpkg.json? Then un-draft this PR so we look at it again.

Thanks for your contribution to vcpkg!

[poor-circle]

Can you describe why the potentially optional dependencies are missing above, or fix them to be explicitly disabled or included in vcpkg.json? Then un-draft this PR so we look at it again.

Thanks for your contribution to vcpkg!

this library will automatic install denpendecies by itself, so i suggest add option to disable it and install denpendecies by vcpkg. they are not optional denpendecies.

[BillyONeal]

this library will automatic install denpendecies by itself

That is not allowed for ports in our curated registry: https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#do-not-use-vendored-dependencies

so i suggest add option to disable it and install denpendecies by vcpkg. they are not optional denpendecies.

Then I think they need to be in the "dependencies" block in vcpkg.json?

[171930433]

this library will automatic install denpendecies by itself

That is not allowed for ports in our curated registry: https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#do-not-use-vendored-dependencies

so i suggest add option to disable it and install denpendecies by vcpkg. they are not optional denpendecies.

Then I think they need to be in the "dependencies" block in vcpkg.json?

1. The glog, spdlog, Protobuf and Flatbuffers libraries are only used during testing or benchmarking.
2. I have already added the vcpkg_cmake_configure with " -DBUILD_BENCHMARK=OFF -DBUILD_EXAMPLES=OFF -
   BUILD_UNIT_TESTS=OFF -DINSTALL_THIRDPARTY=OFF ". The tests and benchmarks will be closed
3. We also add the vcpkg_cmake_configure with -DINSTALL_THIRDPARTY=OFF. This is the option to allow install dependencies by vcpkg

[BillyONeal]

I have already added the vcpkg_cmake_configure with " -DBUILD_BENCHMARK=OFF -DBUILD_EXAMPLES=OFF -
BUILD_UNIT_TESTS=OFF -DINSTALL_THIRDPARTY=OFF ". The tests and benchmarks will be closed

I see, I missed the BUILD_BENCHMARK one. Thanks!

[171930433]

I have already added the vcpkg_cmake_configure with " -DBUILD_BENCHMARK=OFF -DBUILD_EXAMPLES=OFF -
BUILD_UNIT_TESTS=OFF -DINSTALL_THIRDPARTY=OFF ". The tests and benchmarks will be closed

I see, I missed the BUILD_BENCHMARK one. Thanks!

By the way, how to add the introduction of the yalantinglibs library? vcpkg query @BillyONeal

[171930433]

I tested the latest master branch and got an error message with "error: the baseline does not contain an entry for port yalantinglibs" @jimwang118 @dg0yt @BillyONeal Please teach me how to solve this problem.

[jimwang118]

I tested the latest master branch and got an error message with "error: the baseline does not contain an entry for port yalantinglibs" @jimwang118 @dg0yt @BillyONeal Please teach me how to solve this problem.

This means that the code you downloaded does not contain yalantinglibs port. You can check whether there is a yalantinglibs folder in the vcpkg/ports directory. If not, update the vcpkg library.

[dg0yt]

This is a manifest mode message. IIUC you need to update not only the vcpkg checkout but also the project's chosen vcpkg baseline.

[171930433]

This is a manifest mode message. IIUC you need to update not only the vcpkg checkout but also the project's chosen vcpkg baseline.

Thanks. I modified the "default-registry"-"baseline" under "vcpkg-configuration.json" to the latest "master", and the problem has been solved.