Skip to content

Conversation

@Filyus
Copy link

@Filyus Filyus commented Jul 9, 2024

This fixes building librsvg with Cairo on windows for the 20240116.2#2 version, maybe 20240116.2#3 don't needs this already, but probably it needs.

This patch just adds TESTONLY word there:

# Internal-only target, do not depend on directly.
absl_cc_library(
  NAME
    test_allocator
  HDRS
    "internal/test_allocator.h"
  COPTS
    ${ABSL_DEFAULT_COPTS}
  DEPS
    absl::config
    GTest::gmock
  TESTONLY
)

The patch is by SpaceIm and it's taken from there:
https://github.com/conan-io/conan-center-index/blob/832ff6dd9098928c6dd5d222bd780b1240dfed2e/recipes/abseil/all/patches/0004-test-allocator-testonly.patch#L4
with related commit on Conan.io:
conan-io/conan-center-index@a7f4e35

abseil PR - closed and not merged probably because of Contributor License Agreement (CLA):
abseil/abseil-cpp#1536

Related file:
https://github.com/abseil/abseil-cpp/blob/lts_2024_01_16/absl/container/CMakeLists.txt

Package page:
https://vcpkg.io/en/package/abseil

@jimwang118 jimwang118 added the category:port-bug The issue is with a library, which is something the port should already support label Jul 9, 2024
@Filyus
Copy link
Author

Filyus commented Jul 9, 2024

@microsoft-github-policy-service agree

@dg0yt
Copy link
Contributor

dg0yt commented Jul 9, 2024

This patch is already included.

Comment on lines 14 to +15
779a356-test-allocator.diff
0004-test-allocator-testonly.patch # Do not build test_allocator target when tests are disabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess what 779a356-test-allocator.diff is doing...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess what 779a356-test-allocator.diff is doing...

Sorry, my bad...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just leave a link to it: #39664

@data-queue
Copy link
Contributor

I think we can close this PR since the patch file is already included

@data-queue
Copy link
Contributor

Closing, see my comment above

@data-queue data-queue closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants