Skip to content

Conversation

Link1J
Copy link
Contributor

@Link1J Link1J commented Oct 25, 2020

Adds tab completion for Fish.
Fish is shell, like bash, but is not fully POSIX compliant.

@Link1J Link1J marked this pull request as ready for review October 25, 2020 14:39
@PhoebeHui PhoebeHui requested a review from BillyONeal October 26, 2020 05:59
@PhoebeHui PhoebeHui added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed requires:discussion labels Oct 26, 2020
@BillyONeal
Copy link
Member

  1. I'm not sure if we should offer autocomplete for x- options and commands since those aren't intended to be contractual
  2. Since this would be a community supported thing, should we name the whole thing vcpkg integrate install x-fish or something like that?

@Link1J
Copy link
Contributor Author

Link1J commented Oct 27, 2020

Here is my opinion on the points laid out.

  1. Removing the x- options makes sense, and will likely be something I will do.
  2. a) I don't think using x- for community supported items makes sense, but something like c- would.
  3. b) The install part should be used for all of the tab-completes, if it is added. I don't think it should.

@BillyONeal
Copy link
Member

Here is my opinion on the points laid out.

  1. Removing the x- options makes sense, and will likely be something I will do.

Thanks!

  1. a) I don't think using x- for community supported items makes sense, but something like c- would.

Sorry, I should clarify: x- is a marker that the command's behavior might change in the future without warning, and we want the community to have the power to so change features they contribute. I don't think we would want a different prefix there.

  1. b) The install part should be used for all of the tab-completes, if it is added. I don't think it should.

Ah, you're right, I messed that up. Pretend I said vcpkg integrate x-fish :)

@Link1J
Copy link
Contributor Author

Link1J commented Oct 28, 2020

Oh, I misunderstood what x- meant.
I have made the changes.

@BillyONeal
Copy link
Member

@strega-nil @ras0219 and I met today and confirmed that we like doing this feature; dropping requires:discussion

Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as a simple, experimental fish support :)

@BillyONeal BillyONeal merged commit 5407dcd into microsoft:master Nov 3, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants