[cairo] Install the xlib header file when selecting feature x11 #11868
Conversation
JackBoosY
added
category:port-bug
| # Add include directories | ||
| include_directories(".") | ||
| if(CMAKE_SYSTEM_NAME STREQUAL "Windows") | ||
| if(WIN32) |
There was a problem hiding this comment.
Relatively CMake newbie question: Isn't the old code explicitly referencing CMAKE_SYSTEM_NAME better because it's more unambiguously talking about the target system rather than the host/build system?
There was a problem hiding this comment.
I think they are equivalent and better indicate their corresponding platforms.
There was a problem hiding this comment.
I think this is fine for now; vcpkg doesn't really differentiate between a host and a target.
| vcpkg_copy_pdbs() | ||
|
|
||
| vcpkg_test_cmake(PACKAGE_NAME unofficial-cairo) | ||
| #vcpkg_test_cmake(PACKAGE_NAME unofficial-cairo) |
There was a problem hiding this comment.
We probably don't want to check in commented out code...
There was a problem hiding this comment.
This function may be re-enabled in the future, so I just comment it out here to make it easier to mark the port for this function later.
…osoft#11868) * [cairo] Install the xlib header file when selecting feature x11 * update baseline * Update CMakeLists.txt
Currently, the xlib header file in cairo is not installed when feature x11 is activated. Fix it.
Fixes #11813