Skip to content

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Jun 2, 2020

Describe the pull request

@myd7349 myd7349 changed the title Licensepp init [licensepp] Add new port Jun 2, 2020
@PhoebeHui PhoebeHui added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 3, 2020
@PhoebeHui
Copy link
Contributor

@myd7349, thanks for the PR!

The following triplets failed on CI testing, is this expect?
licensepp:arm-uwp
licensepp:x64-uwp

@myd7349 myd7349 marked this pull request as ready for review June 4, 2020 07:59
@JackBoosY
Copy link
Contributor

Will restart CI test after #11742 merged.

@JackBoosY JackBoosY added requires:testing info:reviewed Pull Request changes follow basic guidelines and removed requires:testing labels Jun 10, 2020
@dan-shaw dan-shaw merged commit cb537a2 into microsoft:master Jun 11, 2020
@dan-shaw
Copy link
Contributor

Thanks for the PR!

@myd7349 myd7349 deleted the licensepp-init branch June 11, 2020 08:11
JangBoo pushed a commit to JangBoo/vcpkg that referenced this pull request Jun 18, 2020
* [licensepp] Add new port

* [cryptopp-pem] Update to a newer version that will make lincensepp happy

* Revert "[cryptopp-pem] Update to a newer version that will make lincensepp happy"

This reverts commit 726e3ce.

This version can not compile with cryptopp.

* [licensepp] Finish it

* [licensepp] Fix interface include directory

* [licensepp] Fixup cmake targets

* [licensepp] -O3 is not recognised by msvc

* [licensepp] Fix _iterator_debug_level value mismatch

* [licensepp] Update patch file

* [licensepp] Fail fast on UWP

* [licensepp] Simplify patch file

* [licensepp] Tabs -> Spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants