Skip to content

[v-hacd] Add new port #11606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 11, 2020
Merged

[v-hacd] Add new port #11606

merged 6 commits into from
Jun 11, 2020

Conversation

dhkatz
Copy link
Contributor

@dhkatz dhkatz commented May 27, 2020 •
edited
Loading

Describe the pull request

@NancyLi1013 NancyLi1013 self-assigned this May 27, 2020
@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 27, 2020
@dhkatz
Copy link
Contributor Author

dhkatz commented May 27, 2020

I'm not really sure why the build fails on arm64 or uwp. I'd like to get it working if possible through build options. If not then add them as unsupported. I have no way of testing those directly myself.

@dhkatz dhkatz marked this pull request as ready for review May 27, 2020 07:47
@NancyLi1013
Copy link
Contributor

@dhkatz
This port currently should not support arm.
The errors like this:

4>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\emmintrin.h(24,1): fatal error C1189: #error:  This header is specific to X86 and X64 targets (compiling source file C:\agent\_work\1\s\buildtrees\v-hacd\src\e17ceb9aef-3a5e115dd0\src\VHACD_Lib\src\btAlignedAllocator.cpp) [C:\agent\_work\1\s\buildtrees\v-hacd\arm-uwp-dbg\src\VHACD_Lib\vhacd.vcxproj]
     4>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\emmintrin.h(24,1): fatal error C1189: #error:  This header is specific to X86 and X64 targets (compiling source file C:\agent\_work\1\s\buildtrees\v-hacd\src\e17ceb9aef-3a5e115dd0\src\VHACD_Lib\src\btConvexHullComputer.cpp) [C:\agent\_work\1\s\buildtrees\v-hacd\arm-uwp-dbg\src\VHACD_Lib\vhacd.vcxproj]
     4>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\emmintrin.h(24,1): fatal error C1189: #error:  This header is specific to X86 and X64 targets (compiling source file C:\agent\_work\1\s\buildtrees\v-hacd\src\e17ceb9aef-3a5e115dd0\src\VHACD_Lib\src\vhacdMesh.cpp) [C:\agent\_work\1\s\buildtrees\v-hacd\arm-uwp-dbg\src\VHACD_Lib\vhacd.vcxproj]
     4>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\emmintrin.h(24,1): fatal error C1189: #error:  This header is specific to X86 and X64 targets (compiling source file C:\agent\_work\1\s\buildtrees\v-hacd\src\e17ceb9aef-3a5e115dd0\src\VHACD_Lib\src\vhacdVolume.cpp) [C:\agent\_work\1\s\buildtrees\v-hacd\arm-uwp-dbg\src\VHACD_Lib\vhacd.vcxproj]

So you can add the unsupported info.

@NancyLi1013 NancyLi1013 changed the title Add v-hacd [v-hacd] Add new port May 27, 2020
@dhkatz
Copy link
Contributor Author

dhkatz commented May 27, 2020

@NancyLi1013 Everything seems good now

NancyLi1013
NancyLi1013 reviewed May 28, 2020
View reviewed changes
@NancyLi1013
Copy link
Contributor

Need to test features.

@NancyLi1013
Copy link
Contributor

All features have passed with the following triplets:

  • x86-windows
  • x64-windows
  • x64-windows-static

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:testing labels May 28, 2020
dan-shaw
dan-shaw reviewed Jun 5, 2020
View reviewed changes
ports/v-hacd/fix-cmake.patch
)

configure_file(cmake/vhacd-config.cmake
- "${CMAKE_CURRENT_BINARY_DIR}/vhacd/vhacd-config.cmake"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we are renaming config targets

@dan-shaw dan-shaw merged commit cb0e14c into microsoft:master Jun 11, 2020
@dan-shaw
Copy link
Contributor

Thanks for the PR!

JangBoo pushed a commit to JangBoo/vcpkg that referenced this pull request Jun 18, 2020
@dhkatz @NancyLi1013 @JangBoo
[v-hacd] Add new port (microsoft#11606)
b82b4d0 
* Add v-hacd

* [v-hacd] Fix portfile features

* [v-hacd] Only support static linkage

* [v-hacd] Fix patchfile

* [v-hacd] Remove ARM as a supported platform

* [v-hacd] Update ports/v-hacd/portfile.cmake

Co-authored-by: NancyLi1013 <[email protected]>

Co-authored-by: NancyLi1013 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@dan-shaw dan-shaw dan-shaw left review comments

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@NancyLi1013 NancyLi1013

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhkatz @NancyLi1013 @dan-shaw