Skip to content

Conversation

BillyONeal
Copy link
Member

No description provided.

@BillyONeal BillyONeal added category:port-bug The issue is with a library, which is something the port should already support info:internal labels May 26, 2020
@BillyONeal
Copy link
Member Author

@JackBoosY JackBoosY requested a review from dan-shaw May 26, 2020 05:51
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label May 26, 2020
@dan-shaw dan-shaw added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels May 27, 2020
@BillyONeal BillyONeal force-pushed the rtlsdr_root branch 3 times, most recently from 046c896 to f9d7f73 Compare May 29, 2020 20:10
@BillyONeal
Copy link
Member Author

@dan-shaw The quotes are necessary because the non-quoted version uses the variable name itself, rather than empty string, if the variable is undefined, so I'm going to go back to the original change.

C:\Users\billy\Desktop\demo>type CMakeLists.txt
cmake_minimum_required(VERSION 3.16)
project(demo LANGUAGES)

if (UNDEFINED_VARIABLE STREQUAL "")
set(RESULT_VARIABLE "true")
else()
set(RESULT_VARIABLE "false")
endif()

message(FATAL_ERROR "Result: ${RESULT_VARIABLE}")

C:\Users\billy\Desktop\demo>cmake -G Ninja -S . -B undefined
CMake Error at CMakeLists.txt:10 (message):
Result: false


-- Configuring incomplete, errors occurred!
See also "C:/Users/billy/Desktop/demo/undefined/CMakeFiles/CMakeOutput.log".

C:\Users\billy\Desktop\demo>cmake -G Ninja -DUNDEFINED_VARIABLE="" -S . -B defined_empty
CMake Error at CMakeLists.txt:10 (message):
Result: true


-- Configuring incomplete, errors occurred!
See also "C:/Users/billy/Desktop/demo/defined_empty/CMakeFiles/CMakeOutput.log".

C:\Users\billy\Desktop\demo>

@BillyONeal BillyONeal merged commit 0fc90d9 into microsoft:master May 29, 2020
@BillyONeal BillyONeal deleted the rtlsdr_root branch May 29, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants