[vcpkg metrics] Allow someone to opt out after build #11542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strega-nil
added
category:vcpkg-feature
BillyONeal
reviewed
May 25, 2020
BillyONeal
reviewed
May 25, 2020
BillyONeal
reviewed
May 25, 2020
BillyONeal
reviewed
May 25, 2020
strega-nil
force-pushed
the
metrics
branch
5 times, most recently
from
1fb7228 to
a501139
Compare
Additionally, add floats to the JSON library since they're required.
Additionally, as a drive by, fix UUID generation
BillyONeal
approved these changes
May 26, 2020
dan-shaw
approved these changes
May 27, 2020
BillyONeal
reviewed
May 28, 2020
BillyONeal
approved these changes
May 28, 2020
|
LGTM |
|
@dan-shaw could you message me on teams? |
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* [vcpkg metrics] start using json library Additionally, add floats to the JSON library since they're required. * [vcpkg metrics] allow users to disable metrics after the build Additionally, as a drive by, fix UUID generation * fix metrics data * code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option
--disable-metricsand an environment variableVCPKG_DISABLE_METRICSwhich turn off metrics, even if the binary was built with metrics enabled.Additionally, as a drive-by, we now use the built-in JSON support.
Fixes issue #11542