Skip to content

[azure-storage-cpp] Upgrade to 7.4.0 #11510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2020
Merged

[azure-storage-cpp] Upgrade to 7.4.0 #11510

merged 1 commit into from
May 23, 2020

Conversation

Jinming-Hu
Copy link
Contributor

Describe the pull request

  • What does your PR fix? Version upgrade

  • Which triplets are supported/not supported? Have you updated the CI baseline? All triplets are supported. didn't update the CI baseline.

  • Does your PR follow the maintainer guide? Yes

@Jinming-Hu Jinming-Hu marked this pull request as ready for review May 22, 2020 03:30
NancyLi1013
NancyLi1013 reviewed May 22, 2020
View reviewed changes
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the way to handle copyright as

file(INSTALL
    ${SOURCE_PATH}/LICENSE.txt
    DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)

?

@NancyLi1013 NancyLi1013 self-assigned this May 22, 2020
@NancyLi1013 NancyLi1013 added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels May 22, 2020
@Jinming-Hu
Copy link
Contributor Author

Could you please update the way to handle copyright as

file(INSTALL
    ${SOURCE_PATH}/LICENSE.txt
    DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)

?

Done

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 22, 2020
@NancyLi1013
Copy link
Contributor

LGTM now. @JinmingHu-MSFT Thanks for this PR.

@strega-nil
Copy link
Contributor

@thanks @JinmingHu-MSFT :)

@strega-nil strega-nil merged commit fea6cfe into microsoft:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

+1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jinming-Hu @NancyLi1013 @strega-nil @BillyONeal