Skip to content

[ms-angle] Set ms-angle to empty package #11458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2020
Merged

[ms-angle] Set ms-angle to empty package #11458

merged 3 commits into from
Jun 11, 2020

Conversation

LilyWangL
Copy link
Contributor

Describe the pull request

@LilyWangL LilyWangL requested a review from PhoebeHui May 20, 2020 02:45
@Neumann-A
Copy link
Contributor

If I remember correctly removing a port means vcpkg upgrade does not work any more. That is why qt5-modularscripts still exists.
Instead empty the portfile and print a warning?

PhoebeHui
PhoebeHui approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we should remove it.

@Neumann-A, there is an issue #11482 for track the bug when use 'vcpkg upgrade', I think we need a fix for this.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 21, 2020
@cenit
Copy link
Contributor

cenit commented May 22, 2020

@PhoebeHui it's still true that as of now many deprecated ports have remained as empty, and with a dependency to the new one. It would not be so bad also for backwards compatibility in principle, do you agree?

@ghost
Copy link

ghost commented May 27, 2020

@PhoebeHui it's still true that as of now many deprecated ports have remained as empty, and with a dependency to the new one. It would not be so bad also for backwards compatibility in principle, do you agree?

@cenit I did not think of that. Good idea!

@LilyWangL LilyWangL marked this pull request as ready for review June 4, 2020 02:15
@LilyWangL LilyWangL changed the title [ms-angle] Remove invalid port [ms-angle] Set ms-angle to empty package Jun 4, 2020
@cenit
Copy link
Contributor

cenit commented Jun 4, 2020 •
edited
Loading

@LilyWangL it’s missing a crucial Build-Depends: angle

@PhoebeHui
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dan-shaw dan-shaw merged commit efe434b into microsoft:master Jun 11, 2020
JangBoo pushed a commit to JangBoo/vcpkg that referenced this pull request Jun 18, 2020
@LilyWangL @JangBoo
[ms-angle] Set ms-angle to empty package (microsoft#11458)
0030b79 
* [ms-angle] Remove invalid port

* [ms-angle] Remove invalid port

* [ms-angle] Add build depends angle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@strega-nil strega-nil

@PhoebeHui PhoebeHui

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ms-angle] now an invalid port - needs to be removed
6 participants
@LilyWangL @Neumann-A @cenit @PhoebeHui @strega-nil @dan-shaw