[OpenGL] Fix lib files copy when VCPKG_BUILD_TYPE is set #11294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PhoebeHui
requested changes
May 11, 2020
There was a problem hiding this comment.
@AenBleidd, thanks for the PR!
Could you also update Version to 0.0-6 in CONTROL file?
AenBleidd
force-pushed
the
fix_port_opengl_vcpkg_build_type
branch
from
41367cb to
94ce8db
Compare
|
@PhoebeHui, done. Thanks for the fast review! |
Neumann-A
reviewed
May 11, 2020
Signed-off-by: Vitalii Koshura <[email protected]>
AenBleidd
force-pushed
the
fix_port_opengl_vcpkg_build_type
branch
from
94ce8db to
b8f6d8c
Compare
PhoebeHui
added
info:reviewed
PhoebeHui
approved these changes
May 12, 2020
strega-nil
approved these changes
May 12, 2020
There was a problem hiding this comment.
Some minor changes, but this looks great! Thanks @AenBleidd :)
|
Oops, forgot to merge after I pushed changes; thanks @AenBleidd :D |
|
@strega-nil, thank you too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitalii Koshura [email protected]