[sdformat9] Add new port 🤖 #11265
Merged
[sdformat9] Add new port 🤖 #11265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
suggested changes
May 11, 2020
| # Ruby is required by the sdformat build process | ||
| vcpkg_find_acquire_program(RUBY) | ||
| get_filename_component(RUBY_PATH ${RUBY} DIRECTORY) | ||
| set(_path $ENV{PATH}) |
There was a problem hiding this comment.
Why do we need to add this here?
There was a problem hiding this comment.
It is used later (https://github.com/microsoft/vcpkg/pull/11265/files/e92e8c171b3e52fc0f4343958bd9a54c3cae6575#diff-0aa41acdc3ae5b35d9d840e2c97bd180R29) to restore the original path.
There was a problem hiding this comment.
Thanks for your clarification.
Co-authored-by: NancyLi1013 <[email protected]>
Co-authored-by: NancyLi1013 <[email protected]>
Co-authored-by: NancyLi1013 <[email protected]>
NancyLi1013
approved these changes
May 11, 2020
NancyLi1013
added
info:reviewed
|
Cool, thanks @traversaro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Which triplets are supported/not supported? Have you updated the CI baseline?
urdfdom).Does your PR follow the maintainer guide?
As for the closely related ignition libraries (#7781, https://ignitionrobotics.org/) different major version of sdformat can be installed side by side, so each new major version is added as a new port.
In particular, sdformat9 is a dependency for Gazebo 11 (http://gazebosim.org/blog/gazebo11) and for Ignition Robotics Citadel (that contains Ignition Gazebo 3, see https://www.openrobotics.org/blog/2019/12/11/ignition-citadel-released).