[vcpkg] Hopefully fix build on macOS 10.13/10.14 #11205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should do a full rebuild for this since we don't include the ninja version in the keys if I'm not mistaken. Do we need an erase archives task like the clean tombstones one? |
BillyONeal
approved these changes
May 6, 2020
|
@BillyONeal Probably! |
|
oops, accidentally deleted the branch |
|
Alright, given that no one has commented saying this breaks them, I'm okay with merging. |
|
Sorry, I can't test this, because my code relies on |
|
The PR in the end didn’t roll back ninja, but also for me it’s not a problem anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @cenit @acgetchell
Rolls back ninja to v1.9.0, and fixes the check for AppleClang