Skip to content

Conversation

edmBernard
Copy link
Contributor

Add more granularity for dlib feature.
the PR don't change default dlib build

we can now use dlib without fftw3 using dlib[core]

I'm not sure if I need to bump the version.

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL self-requested a review May 7, 2020 02:14
@LilyWangL LilyWangL self-assigned this May 7, 2020
@LilyWangL
Copy link
Contributor

Add more granularity for dlib feature.
the PR don't change default dlib build

we can now use dlib without fftw3 using dlib[core]

I'm not sure if I need to bump the version.

Thanks for your PR. You need modify the version in CONTROL file.

@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels May 7, 2020
@strega-nil
Copy link
Contributor

I'm good with this; thanks @edmBernard :)

@strega-nil strega-nil merged commit c985d75 into microsoft:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants