Skip to content

Conversation

UnaNancyOwen
Copy link
Contributor

Fix deploy Azure Kinect Sensor SDK on Windows by copy Depth Engine.
Get Depth Engine from NuGet package.

Describe the pull request

Fix deploy Azure Kinect Sensor SDK on Windows by copy Depth Engine.
@UnaNancyOwen
Copy link
Contributor Author

@jasjuang Please test this change on your environments. Thanks,

@UnaNancyOwen UnaNancyOwen changed the title Fix Deploy Azure Kinect Sensor SDK on Windows [azure-kinect-sensor-sdk] Fix Deploy Azure Kinect Sensor SDK on Windows May 3, 2020
@jasjuang
Copy link
Contributor

jasjuang commented May 3, 2020

@UnaNancyOwen sorry I moved away from Azure Kinect a few months ago because of microsoft/Azure-Kinect-Sensor-SDK#803, thanks for the PR but I don't have the device to test it now

@UnaNancyOwen
Copy link
Contributor Author

UnaNancyOwen commented May 4, 2020

@jasjuang OK, Thanks. I think this change will work correctly. This change for if you come back to Azure Kinect again. :) 👍

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

It looks like there are some regressions here, please get logs here.

@UnaNancyOwen
Copy link
Contributor Author

@JackBoos Oops, that's a little mistake. I've fixed it. Thanks,

@JackBoosY
Copy link
Contributor

DLLs should not be present in a static build, but the following DLLs were found:

    C:/agent/_work/2/s/packages/azure-kinect-sensor-sdk_x64-windows-static/bin/depthengine_2_0.dll
    C:/agent/_work/2/s/packages/azure-kinect-sensor-sdk_x64-windows-static/debug/bin/depthengine_2_0.dll

There should be no bin\ directory in a static build, but C:\agent\_work\2\s\packages\azure-kinect-sensor-sdk_x64-windows-static\bin is present.
There should be no debug\bin\ directory in a static build, but C:\agent\_work\2\s\packages\azure-kinect-sensor-sdk_x64-windows-static\debug\bin is present.
If the creation of bin\ and/or debug\bin\ cannot be disabled, use this in the portfile to remove them

    if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
        file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/bin" "${CURRENT_PACKAGES_DIR}/debug/bin")
    endif()

Found 2 error(s). Please correct the portfile:
    C:\agent\_work\2\s\ports\azure-kinect-sensor-sdk\portfile.cmake

@UnaNancyOwen
Copy link
Contributor Author

@JackBoos Hmm, This SDK doesn't seem to support statical linkage, so I added a check.

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels May 7, 2020
@strega-nil strega-nil self-assigned this May 8, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

That was a weird bug in the CI... well, whatevs! Thanks for fixing this @UnaNancyOwen :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants